Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Correct model name when IV is OLS #186

Merged
merged 5 commits into from Dec 20, 2018
Merged

BUG: Correct model name when IV is OLS #186

merged 5 commits into from Dec 20, 2018

Conversation

bashtage
Copy link
Owner

Ensure correct model name when IV reduces to OLS when
endog and instr are empty arrays

closes #185

Ensure correct model name when IV reduces to OLS when
endog and instr are empty arrays
Add new method to test hypothesis test
Update to use .codes rather than .lables to avoid FutureWarnings
Ensure all code accepts None rather than 0-dim arrays
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #186 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #186      +/-   ##
=========================================
- Coverage   99.81%   99.8%   -0.01%     
=========================================
  Files          79      79              
  Lines       13228   13235       +7     
  Branches     1279    1249      -30     
=========================================
+ Hits        13203   13209       +6     
- Misses          4       5       +1     
  Partials       21      21
Impacted Files Coverage Δ
linearmodels/typing/iv.py 100% <ø> (ø) ⬆️
linearmodels/iv/gmm.py 100% <ø> (ø) ⬆️
...models/tests/panel/test_simulated_against_stata.py 100% <100%> (ø) ⬆️
linearmodels/iv/data.py 98.16% <100%> (-1.84%) ⬇️
linearmodels/panel/results.py 99.7% <100%> (ø) ⬆️
linearmodels/tests/panel/test_pooled_ols.py 100% <100%> (ø) ⬆️
linearmodels/tests/system/test_sur.py 100% <100%> (ø) ⬆️
linearmodels/asset_pricing/results.py 100% <100%> (ø) ⬆️
linearmodels/tests/panel/test_formula.py 100% <100%> (ø) ⬆️
linearmodels/system/model.py 99.87% <100%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57760a...5a44e7a. Read the comment docs.

Add wald_test as a convenience function for panel models
Apply isort to sort order
@bashtage bashtage force-pushed the fix-model-name branch 2 times, most recently from a58e623 to 48fb84d Compare December 20, 2018 10:17
Ensure wald_test isn't called in automatic attribute checks
@bashtage bashtage merged commit ff064c4 into master Dec 20, 2018
@bashtage bashtage deleted the fix-model-name branch December 20, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title of summary table for IV-2SLS and the Name of Estimator inside the output table
1 participant