Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/MAINT: Correct uinteger buffering in SFMT and dSFMT #161

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

bashtage
Copy link
Owner

Remove unused buffers from dSFMT
Add to reset in SFMT
Add test for these

Remove unused buffers from dSFMT
Add to reset in SFMT
Add test for these
@pep8speaks
Copy link

Hello @bashtage! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 369:21: E231 missing whitespace after ','
Line 375:30: E231 missing whitespace after ','
Line 384:21: E231 missing whitespace after ','
Line 391:37: E231 missing whitespace after ','

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #161 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #161     +/-   ##
=========================================
+ Coverage   95.16%   95.36%   +0.2%     
=========================================
  Files          33       34      +1     
  Lines        9155     9706    +551     
  Branches      134      152     +18     
=========================================
+ Hits         8712     9256    +544     
- Misses        421      427      +6     
- Partials       22       23      +1
Impacted Files Coverage Δ
randomgen/dsfmt.pyx 92.78% <ø> (-2.07%) ⬇️
randomgen/tests/test_direct.py 99.27% <100%> (+0.05%) ⬆️
randomgen/sfmt.pyx 94.17% <100%> (+1.1%) ⬆️
randomgen/hc128.pyx 94.2% <0%> (ø)
randomgen/aes.pyx 90.07% <0%> (+0.16%) ⬆️
randomgen/tests/test_smoke.py 98.66% <0%> (+0.21%) ⬆️
randomgen/mt19937.pyx 92.85% <0%> (+0.35%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b2b41...6662411. Read the comment docs.

@bashtage bashtage merged commit 4a18102 into master Jun 26, 2019
@bashtage bashtage deleted the sfmt-uint branch June 26, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants