Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Sync upstream bug fixes #201

Merged
merged 1 commit into from
Jun 3, 2020
Merged

BUG: Sync upstream bug fixes #201

merged 1 commit into from
Jun 3, 2020

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Jun 3, 2020

Sync with 1.19 bug fixes

@pep8speaks
Copy link

pep8speaks commented Jun 3, 2020

Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 279:1: E302 expected 2 blank lines, found 1

Comment last updated at 2020-06-03 21:28:06 UTC

@bashtage bashtage force-pushed the sync-upstream branch 6 times, most recently from 2c38266 to 4c1239d Compare June 3, 2020 18:55
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #201 into master will decrease coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   98.12%   98.10%   -0.02%     
==========================================
  Files          40       41       +1     
  Lines       10436    10498      +62     
  Branches      167      169       +2     
==========================================
+ Hits        10240    10299      +59     
- Misses        173      176       +3     
  Partials       23       23              
Impacted Files Coverage Δ
randomgen/mtrand.pyx 99.64% <71.42%> (-0.36%) ⬇️
randomgen/generator.pyx 98.92% <87.50%> (-0.14%) ⬇️
randomgen/tests/test_generator_117.py 100.00% <100.00%> (ø)
randomgen/tests/test_recent_numpy_changes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437bdf5...8e319a2. Read the comment docs.

@bashtage bashtage changed the title BUG: Sync upstream big fixes BUG: Sync upstream bug fixes Jun 3, 2020
Sync with 1.19 bug fixes
@bashtage bashtage merged commit 0fcecd9 into master Jun 3, 2020
@bashtage bashtage deleted the sync-upstream branch June 3, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants