Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mtrand randomstate #56

Merged
merged 6 commits into from
Mar 31, 2019
Merged

Mtrand randomstate #56

merged 6 commits into from
Mar 31, 2019

Conversation

bashtage
Copy link
Owner

No description provided.

Add a RandomState class that mirrors NumPy
Clean docstring differences between randomgen and numpy
Add tests for edge cases not testes
Carefully sync docstrings between numpy and RandomState
Ensure coverage is as close to 100% as possible
Move the lock to the BasicRNG
Use a single copy or _randint_types
Correct 64bit test values for maxint
@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@055b2e1). Click here to learn what that means.
The diff coverage is 99.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage          ?   90.27%           
=========================================
  Files             ?       30           
  Lines             ?     8204           
  Branches          ?      127           
=========================================
  Hits              ?     7406           
  Misses            ?      777           
  Partials          ?       21
Impacted Files Coverage Δ
randomgen/mtrand.pyx 87.73% <ø> (ø)
randomgen/legacy/_legacy.pyx 59.42% <100%> (ø)
randomgen/generator.pyx 88.03% <100%> (ø)
randomgen/mt19937.pyx 81.11% <75%> (ø)
randomgen/tests/test_randomstate_regression.py 98.94% <98.94%> (ø)
randomgen/tests/test_randomstate.py 99.3% <99.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055b2e1...3fe178d. Read the comment docs.

@bashtage bashtage merged commit fb8c3f1 into master Mar 31, 2019
@bashtage bashtage deleted the mtrand-randomstate branch April 8, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant