Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove LegacyGenerator #62

Merged
merged 2 commits into from
Apr 1, 2019
Merged

MAINT: Remove LegacyGenerator #62

merged 2 commits into from
Apr 1, 2019

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Apr 1, 2019

Remove LegacyGenerator since it has been replaced by RandomState

Remove LegacyGenerator since it has been replaced by RandomState
Enfore PEP8 where sensible in the pyx and pxd files
Refactor the cffi and ctypes interface to be shared
@bashtage
Copy link
Owner Author

bashtage commented Apr 1, 2019

This pull request fixes 3 alerts when merging 11320c2 into 7779c6e - view on LGTM.com

fixed alerts:

  • 3 for Explicit export is not defined

Comment posted by LGTM.com

@bashtage bashtage merged commit d98e7cb into master Apr 1, 2019
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #62 into master will decrease coverage by <.01%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files          28       26       -2     
  Lines        7995     7701     -294     
  Branches      128      122       -6     
==========================================
- Hits         7334     7064     -270     
+ Misses        639      617      -22     
+ Partials       22       20       -2
Impacted Files Coverage Δ
randomgen/entropy.pyx 87.5% <ø> (-0.18%) ⬇️
randomgen/pickle.py 84.21% <ø> (+1.23%) ⬆️
randomgen/legacy/__init__.py 0% <0%> (-100%) ⬇️
randomgen/generator.pyx 90.59% <100%> (+0.01%) ⬆️
randomgen/mtrand.pyx 90.41% <100%> (+0.01%) ⬆️
randomgen/pcg32.pyx 76.41% <100%> (-2.66%) ⬇️
randomgen/threefry32.pyx 79.52% <100%> (-2.3%) ⬇️
randomgen/dsfmt.pyx 78.94% <100%> (-1.95%) ⬇️
randomgen/pcg64.pyx 79.33% <100%> (-1.92%) ⬇️
randomgen/threefry.pyx 81.06% <100%> (-1.53%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7779c6e...11320c2. Read the comment docs.

@bashtage bashtage deleted the drop-legacy branch April 8, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant