Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code to support Django 4 and up, edge case for code older than 3.2 #40

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

c-goosen
Copy link
Contributor

Past django 3.2 there was a breaking change in the middleware I fixed before, but forgot to account for newer version in logic. This should be the required fix for that

@c-goosen
Copy link
Contributor Author

@shanx

@shanx
Copy link
Collaborator

shanx commented Jul 19, 2022

Hi @c-goosen thanks for the PR! @bashu took over maintenance for this library. @bashu do you have time to look into this?

@bashu bashu merged commit 84ad3d4 into bashu:develop Jul 20, 2022
@c-goosen
Copy link
Contributor Author

Thank you both, appreciate the effort

@shanx
Copy link
Collaborator

shanx commented Jul 20, 2022

Thanks for the improvement!!

@FranckBoyer FranckBoyer mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants