Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation between data and data visualization in Track and Location objects #20

Closed
GrazianoCapelli opened this issue Mar 21, 2017 · 2 comments
Assignees
Labels
enhancement This is an enhancement of an existing feature

Comments

@GrazianoCapelli
Copy link
Member

There are many good reasons to divide the data string formatting from the numeric data:

  • Removal of the duplication of code between Track and Location objects;
  • We'll have Track and Location objects smaller, using less memory allocation, specially useful when load Location lists during exportation;
  • Separation between data (access to DB) and data visualization (access to app strings);
  • General performances improvements;
  • We'll allow to easily implement the translations of the units of measurement;

The implementation of PhysicalData.java and PhysicalDataFormatter.java is started.
The goal is to add this improvement in the next app update.

@GrazianoCapelli GrazianoCapelli added the enhancement This is an enhancement of an existing feature label Mar 21, 2017
@GrazianoCapelli GrazianoCapelli self-assigned this Mar 21, 2017
@GrazianoCapelli
Copy link
Member Author

Separation done and published in commit 5ffec20.
Now Units of Measurement are put in strings.xml, and fully translatable.

100% ready to add translation starting from the next update.

@JLJu
Copy link
Member

JLJu commented Mar 25, 2017

Great. Strings translated to Spanish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants