Install Mocha as a development dependency

[rowanmanning]

I don't know if you're adverse to this, but it means one less step for new contributors if you install Mocha as a development dependency. It caught me out for just a second :)

[rowanmanning]

Oops, accidentally deleted my branch! Sorry for spam

[M-Zuber]

Looks good to me, but I'll let @basicallydan sign off on this one

[basicallydan]

Probably a stupid question: doesn't Mocha require global installation to
work? And therefore, not possible to put into dev deps? Or have I been
living under false pretences?

If I'm wrong, that's a great idea!
On 1 Dec 2015 18:32, "Mordechai Zuber" notifications@github.com wrote:

Looks good to me, but I'll let @basicallydan
https://github.com/basicallydan sign off on this one

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

[M-Zuber]

I had a feeling that there was more to this. Glad I didn't just merge. 😁

[rowanmanning]

Mocha's fine as a local dependency, running it like this in all of mine and my company's projects :) you just need to reference the bin within node_modules instead.

Same with JSHint et al.

[rowanmanning]

Realise that's quite anecdotal. More solid example: Express includes Mocha in the dev dependencies, and that project was created by the author of Mocha https://github.com/strongloop/express/blob/master/package.json

[basicallydan]

I see. That's a good idea. Okay. Also means we can control the version I
suppose! I haven't actually looked at the code yet as I'm currently on my
phone but as long as it all works then it sounds fine to me!
On 1 Dec 2015 18:41, "Rowan Manning" notifications@github.com wrote:

Realise that's quite anecdotal. More solid example: Express includes Mocha
in the dev dependencies, and that project was created by the author of
Mocha https://github.com/strongloop/express/blob/master/package.json

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

[M-Zuber]

I'll merge as the code looks like a simple change.
Hope nothing goes :bang: