Merge pull request #100 from basil79/slot-should-be-visible-hide-vide…

…o-slot-instead changed slot to be always visible to allow VPAID's detect visibility o…
basil79 · Mar 26, 2023 · 06b78c0 · 06b78c0
2 parents ebca255 + 4c682ee
commit 06b78c0
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 10 deletions.
diff --git a/dist/ads-manager.es.js b/dist/ads-manager.es.js
diff --git a/dist/ads-manager.js b/dist/ads-manager.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ads-manager",
-  "version": "1.2.10",
+  "version": "1.2.11",
   "description": "HTML5 Video Ads Manager based on @dailymotion/vast-client",
   "publishConfig": {
     "registry": "https://registry.npmjs.org"

diff --git a/public/iframe.html b/public/iframe.html
@@ -2,7 +2,7 @@
 <html>
 <head>
     <meta charset="UTF-8">
-    <title>Ads Manager</title>
+    <title></title>
 </head>
 <body>
 

diff --git a/public/iframe2.html b/public/iframe2.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta charset="UTF-8">
+    <title></title>
+</head>
+<body>
+
+<iframe src="iframe.html" width="100%" height="600px"></iframe>
+
+</body>
+</html>
diff --git a/public/js/ads-manager.js b/public/js/ads-manager.js
diff --git a/src/ads-manager.js b/src/ads-manager.js
@@ -187,7 +187,7 @@ AdsManager.prototype.createSlot = function() {
   console.log('create slot......');
   this._slot = document.createElement('div');
   this._slot.style.position = 'absolute';
-  this._slot.style.display = 'none';
+  //this._slot.style.display = 'none';
   this._adContainer.appendChild(this._slot);
   this.createVideoSlot();
 };
@@ -218,12 +218,16 @@ AdsManager.prototype.createVideoSlot = function() {
   this._videoSlot.style.width = '100%';
   this._videoSlot.style.height = '100%';
   this._videoSlot.style.backgroundColor = 'rgb(0, 0, 0)';
+  this._videoSlot.style.display = 'none';
   //this._adContainer.appendChild(this._videoSlot);
   this._slot.appendChild(this._videoSlot);
 };
 AdsManager.prototype.hideVideoSlot = function() {
   this._videoSlot.style.display = 'none';
 };
+AdsManager.prototype.showVideoSlot = function() {
+  this._videoSlot.style.display = 'block';
+};
 AdsManager.prototype.stopVASTMediaLoadTimeout = function() {
   if(this._vastMediaLoadTimer) {
     clearTimeout(this._vastMediaLoadTimer);
@@ -303,7 +307,12 @@ AdsManager.prototype.onAdSizeChange = function() {
 AdsManager.prototype.onAdStarted = function() {
   this._hasStarted = true;
   // Show ad slot
-  this.showSlot();
+  //this.showSlot();
+  if(this._videoSlot.src === '') {
+    this.hideVideoSlot();
+  } else {
+    this.showVideoSlot();
+  }
   this._callEvent(this.EVENTS.AdStarted);
 };
 AdsManager.prototype.onAdVideoStart = function() {
@@ -1164,7 +1173,8 @@ AdsManager.prototype.abort = function() {
   this._videoSlot.load();
 
   // Hide slot
-  this.hideSlot();
+  //this.hideSlot();
+  this.hideVideoSlot();
 
 };
 AdsManager.prototype.destroy = function() {