Merge pull request #89 from basil79/adpod-refactoring

fixed set volume for iOS
basil79 · Feb 6, 2023 · be14a97 · be14a97
2 parents f9d5f2a + 333126b
commit be14a97
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/dist/ads-manager.es.js b/dist/ads-manager.es.js
diff --git a/dist/ads-manager.js b/dist/ads-manager.js
diff --git a/public/index.html b/public/index.html
@@ -68,7 +68,7 @@ <h3>Ad Events:</h3>
 <br/>
 <br/>
 
-<script src="js/ads-manager.js?v=14"></script>
+<script src="js/ads-manager.js?v=21"></script>
 <script src="js/index.js?v=20"></script>
 
 

diff --git a/public/js/ads-manager.js b/public/js/ads-manager.js
diff --git a/src/ads-manager.js b/src/ads-manager.js
@@ -1060,13 +1060,15 @@ AdsManager.prototype.setVolume = function(volume) {
     if (this._isVPAID) {
       this._isCreativeFunctionInvokable('setAdVolume') && this._vpaidCreative.setAdVolume(volume);
     }
-    const isVolumeChanged = volume !== this._videoSlot.volume;
+    const isVolumeChanged = volume !== (this._videoSlot.muted ? 0 : this._videoSlot.volume);
     if(isVolumeChanged) {
       this._attributes.volume = volume;
-      if(volume !== 0) {
+      if(this._attributes.volume !== 0) {
         this._videoSlot.muted = false;
+      } else {
+        this._videoSlot.muted = true;
       }
-      this._videoSlot.volume = volume;
+      this._videoSlot.volume = this._attributes.volume;
       this.onAdVolumeChange();
     }
   }