Migrate alarm switch to alarm control panel (clean from master) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks again! |
|
@vlebourl I do have some issues with the alarm trigger: once you set the device to stolen, and the alarm is enabled, then it will be in the triggered state. I think it should only be in the triggered state when the device reports that the alarm triggered. I can see if I can emit an event, to automatically enable the stolen state in that case (but leave it up to the user to configure it that way). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the duplicate, but I actually don't really know how to rebase onto master from the previous branch... So I made a clean one from current master. Hope that helps.
Cheers.