Fix a bug with variadic function arity validation

src/basilisp/lang/compiler/analyzer.py

@@ -1917,13 +1917,6 @@ def _fn_ast(  # pylint: disable=too-many-branches
         fixed_arity_for_variadic: Optional[int] = None
         num_variadic = 0
         for arity in arities:
-            if fixed_arity_for_variadic is not None:
-                if arity.fixed_arity >= fixed_arity_for_variadic:
-                    raise AnalyzerException(
-                        "fn may not have a method with fixed arity greater than "
-                        "fixed arity of variadic function",
-                        form=arity.form,
-                    )
             if arity.is_variadic:
                 if num_variadic > 0:
                     raise AnalyzerException(

tests/basilisp/compiler_test.py

@@ -2606,18 +2606,26 @@ def test_multi_arity_fn_cannot_have_two_variadic_methods(
         with pytest.raises(compiler.CompilerException):
             lcompile(code)
 
+    @pytest.mark.parametrize(
+        "code",
+        [
+            """
+            (def f
+              (fn* f
+                ([s] (concat [s] :one-arg))
+                ([& args] (concat [:rest-params] args))))""",
+            """
+            (def f
+              (fn* f
+                ([& args] (concat [:rest-params] args))
+                ([s] (concat [s] :one-arg))))""",
+        ],
+    )
     def test_variadic_method_cannot_have_lower_fixed_arity_than_other_methods(
-        self, lcompile: CompileFn
+        self, lcompile: CompileFn, code: str
     ):
         with pytest.raises(compiler.CompilerException):
-            lcompile(
-                """
-                (def f
-                  (fn* f
-                    ([s] (concat [s] :one-arg))
-                    ([& args] (concat [:rest-params] args))))
-                """
-            )
+            lcompile(code)
 
     def test_multi_arity_fn_dispatches_properly(
         self, lcompile: CompileFn, ns: runtime.Namespace