RD-1983 add support for topics and keyphrases #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected Double confidence; | ||
| protected String conceptId; | ||
|
|
||
| public Builder(String concept, Double confidence, String conceptId) { |
There was a problem hiding this comment.
Seems you want a default constructor (or minimum requirement only) also, or you can skip other methods..?
iredpath
commented
Jun 23, 2017
| private final Double confidence; | ||
| private final String conceptId; | ||
|
|
||
| public Topic() throws Exception { |
There was a problem hiding this comment.
whoops, this wasn't meant to make it in. Will remove
guruxu
reviewed
Jun 27, 2017
| @JsonCreator | ||
| ConceptMixin(@JsonProperty("concept") String concept, | ||
| @JsonProperty("salience") Double salience, | ||
| @JsonProperty("conceptId") String topicId, |
There was a problem hiding this comment.
is this intentionally different between json and java?
There was a problem hiding this comment.
nope, just missed in the big concept <-> topic switch. pushed a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.