Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

Fix K8s service data source usage #69

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix K8s service data source usage #69

merged 1 commit into from
Oct 6, 2020

Conversation

chrissng
Copy link
Contributor

@chrissng chrissng commented Oct 2, 2020 •
edited
Loading

During initial apply of the consul module, one could get an error like this:

Error: services "consul-dns" not found

  on .terraform/modules/consul/modules/consul/dns.tf line 4, in data "kubernetes_service" "consul_dns":
   4: data "kubernetes_service" "consul_dns" {

This is due to the helm release containing the k8s service not yet being deployed.

PR changes to use helm_release.consul.metadata[0] as the metadata is an attribute that is only known after apply.

@chrissng chrissng marked this pull request as ready for review October 2, 2020 10:27
@chrissng chrissng merged commit 043d42e into master Oct 6, 2020
@chrissng chrissng deleted the fix-k8s-service-data-source branch October 6, 2020 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lawliet89 lawliet89 lawliet89 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrissng @lawliet89