Destroy test environment when test is done and file syncing switched off (fixes #10) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahmatiy
requested changes
Sep 26, 2016
| @@ -210,11 +210,10 @@ module.exports = function createAssert(scope, testCode, settings){ | |||
|
|
|||
| try { | |||
| asyncQueue.shift().call(); | |||
| __processAsync(); | |||
There was a problem hiding this comment.
Why you move it to try clause? In that case on call() exception async queue will never be processed and test never be done.
There was a problem hiding this comment.
On exception test gets done in __exception call in catch block . If call __processAsync() after try/catch clause testDone is called twice.
| this.createScope_ = null; | ||
| this.scopes.forEach(function(scope){ | ||
| scope.destroy(); | ||
| }); | ||
| this.scopes = null; | ||
|
|
||
| if (this.html) |
There was a problem hiding this comment.
Why not just this.html = null? I think if is redundant here
| } | ||
| }); | ||
| fileSync.link(null, function(value){ | ||
| doneTestCasesAndSuites.source.setSource(value ? null : testsToRun); |
There was a problem hiding this comment.
source: new Extract({
source: fileSync.as(function(value){
return value ? null : testsToRun;
}),
rule: function(test){
return test.parentNode || test;
}
}),There was a problem hiding this comment.
This will end up with codestyle error, because doneTestCasesAndSuites defined but not used.
| @@ -24,7 +24,7 @@ function findTest(test, filename){ | |||
| } | |||
| } | |||
|
|
|||
| function loadTests(data, autorun, notifyLoaderFunction){ | |||
| function loadTests(data, autorun, fileSync, notifyLoaderFunction){ | |||
There was a problem hiding this comment.
I think new argument should be appended, since notifyLoaderFunction may using by some one.
lahmatiy
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.