Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] added OpenDrain to the allowed LineFormat conditions for setLineMode #168

Closed
wants to merge 2 commits into from

Conversation

alireza-moayyedi
Copy link
Contributor

I am using the a2A4504-18umPRO camera and I want to set the line mode to output. This is doable through the pylon viewer and I have already tested everything in my system and it works fine. However, the wrapper was missing this condition.

@FrancoisPicardDTI
Copy link
Collaborator

Hello @alireza-moayyedi
Thank you for your contribution.
I changed a bit the behavior of the setLineMode function. Would you mind testing the PR168_change_setLineMode_behavior branch and tell me if it fits your need?
The LineFormat node is read-only and could be (but must not) used to figure out, if a Line X selected in the LineSelector does support also LineMode= Output (wich is true for Lines 2 and 3), or Input (Line 1) only. The new code should allow now more flexibility.

@alireza-moayyedi
Copy link
Contributor Author

Hello @FrancoisPicardDTI
Thanks for the changes and sorry for the late reply. I wanted to test it first and get back to you here but unfortunately I do not have access to that specific setup at the time being. Hence I cannot test your changes. If I ever get the chance to test it I will update this thread. Thanks again for looking into it, much appreciated.

@FrancoisPicardDTI
Copy link
Collaborator

My pleasure. I am closing it then.

@alireza-moayyedi
Copy link
Contributor Author

alireza-moayyedi commented Apr 26, 2024

@FrancoisPicardDTI Hello, I finally got the chance to test PR168_change_setLineMode_behavior and it worked perfectly fine:

ros2 service call  /my_camera/pylon_ros2_camera_node/set_line_mode pylon_ros2_camera_interfaces/srv/SetIntegerValue "value: 1" 
waiting for service to become available...
requester: making request: pylon_ros2_camera_interfaces.srv.SetIntegerValue_Request(value=1)

response:
pylon_ros2_camera_interfaces.srv.SetIntegerValue_Response(success=True, message='done')

Thanks for the fix. By the way, I tried to make a PR for your commit on PR168_change_setLineMode_behavior into Humble but unfortunately I got the "Pull request creation failed. Validation failed: must be a collaborator" error. Could you please add it into Humble?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants