Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify icons #47

Closed
basmilius opened this issue Aug 26, 2019 · 1 comment
Closed

Unify icons #47

basmilius opened this issue Aug 26, 2019 · 1 comment
Assignees
@basmilius
Labels
Component Issue has to do with components. CSS Something in css. Enhancement Enhancement to an existing feature. JS Something in js.

Comments

@basmilius
Copy link
Owner

What
Latte UI uses materialdesignicons.com as it's core icon library, as Latte UI is now used by other people we should also support other icon libraries. For CSS I already created a $latte-icon-class variable.

Proposal
Create an icon factory that can be overridden in Vue.use(LatteUI, {...}) and provide some defaults.

Target version
1.8.0
@basmilius basmilius added Component Issue has to do with components. Enhancement Enhancement to an existing feature. CSS Something in css. JS Something in js. labels Aug 26, 2019
@basmilius basmilius self-assigned this Aug 26, 2019
basmilius added a commit that referenced this issue Aug 26, 2019
@basmilius
Refactored latest mdi stuff in css to icon #47
005a6b0
basmilius added a commit that referenced this issue Aug 26, 2019
@basmilius
More work on unifying icons #47
651abd9
basmilius added a commit that referenced this issue Aug 26, 2019
@basmilius
Refactored more icons to the new Icon component #47
be8d121
@basmilius
Copy link
Owner Author

Going to close this, it works as desired, but need to update even more in 1.9.

@basmilius basmilius mentioned this issue Sep 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@basmilius basmilius

Labels
Component Issue has to do with components. CSS Something in css. Enhancement Enhancement to an existing feature. JS Something in js.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@basmilius