Only start adapting on light.turn_on when detect_non_ha_changes: false to prevent unwanted light turn ons

[basnijholt]

Great news, there might be a solution to the 'lights turning on by itself'-issue! 🎉 🚀

I also had a major insight yesterday going through the code line-by-line.

I believe the issue of lights turning on is always because for some reason: the light will incorrectly report its state as on! (as mentioned by @th3w1zard1 above).

Because AL then notices a state change, and this state is likely not precisely what it should be according to AL, it will adapt it to the correct state, inadvertently turning the lights on.

In this PR, I have made some changes. With that code when detect_non_ha_changes: false and there is a 'off' → 'on' state change which is not the result of a light.turn_on, it will mark the light as manually controlled and not adapt it at all.

I have one light at home which frequently turns on again after I turned it off, I will see whether this still happens with the changes. If not, I will merge and release a new version.

ref #10, #622, #85

[th3w1zard1]

I'm very lost here, but if it works, it works right? 😅

[janpf]

Hi, thanks for your work :)
Quick question, does this possibly interfere with my setup?: I have a few lights behind a physical switch, which after turning on using the physical switch (non-home assistant) don't get automatically changed. This reads like this could be reason. Is there a way to make this setup work after this patch?

[basnijholt]

Unfortunately, the only workaround is detect_non_ha_changes: true because there is really no way to distinguish between HA:

1. reporting a state change with state: on because you turned it on outside of HA
2. reporting a state change with state: on which is the light reporting an incorrect state, which turns on the light (if detect_non_ha_changes: true)