Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapt_only_on_bare_turn_on which instantly triggers manual_control when turning on with brightness or color #709

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

basnijholt
Copy link
Owner

@basnijholt basnijholt commented Aug 6, 2023

This PR adds a configuration option adapt_only_on_bare_turn_on, which when enabled doesn't adapt lights when initially turning them when there is color or brightness in the service_data.

To not change the behavior for anyone, the option is false by default.

Closes #12, #89, #271, #314, #416, #435, #528, #581

@basnijholt basnijholt changed the title Add adapt_only_on_bare_turn_on which instantly triggers manual_control when setting brightness or color Add adapt_only_on_bare_turn_on which instantly triggers manual_control when setting brightness or color Aug 6, 2023
@basnijholt basnijholt changed the title Add adapt_only_on_bare_turn_on which instantly triggers manual_control when setting brightness or color Add adapt_only_on_bare_turn_on which instantly triggers manual_control when turning on with brightness or color Aug 6, 2023
@basnijholt basnijholt force-pushed the adapt-on-empty-turn-on-only branch 6 times, most recently from eea0aa0 to a32750d Compare August 6, 2023 03:33
…trol` when turning on with brightness or color
@basnijholt basnijholt merged commit d44cb66 into main Aug 6, 2023
15 checks passed
@basnijholt basnijholt deleted the adapt-on-empty-turn-on-only branch August 6, 2023 03:56
@TheAlphaLaw
Copy link

@basnijholt Is it possible to add a feature that let's you select whether brightness or temperature triggers this? For example, I may want to call the light to 100% brightness but still want the temperature to adapt or vice versa.

This feature is exactly what my wife has been asking for :) Thank you!

@basnijholt
Copy link
Owner Author

@TheAlphaLaw that’s a good idea. However, this would be quite some work and require fixing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat lights in a scene as manually controlled
2 participants