Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-header-background-color should change to match theme colors. #42

Open
okets opened this issue Nov 10, 2022 · 4 comments
Open

app-header-background-color should change to match theme colors. #42

okets opened this issue Nov 10, 2022 · 4 comments

Comments

@okets
Copy link

okets commented Nov 10, 2022

Hello there,
I have an aesthetic request to improve your awesome themes:
app-header-background-color does not match the color scheme of most themes.
in my opinion, it should be the same (or compliment) as the background color used in the theme.
orange themes shouldn't have a brown header, it should be as orange as the background.

@basnijholt
Copy link
Owner

I am setting the color using the average color that I create like this:

def average_color(fname):
color = Image.open(fname).resize((1, 1)).getpixel((0, 0))
hex_color = "#{:02x}{:02x}{:02x}".format(*color)
rgb_color = ImageColor.getrgb(hex_color)
return "rgba({}, {}, {}, 0.4)".format(*rgb_color)

If you have a better suggestion (or would like to pick colors), let me know! 😄

@okets
Copy link
Author

okets commented Nov 20, 2022

Hello @basnijholt ,
Thank you for the quick response, I love your themes and am thankful for all the hard work put into them.

In my opinion, average colors don't complement the above-header color.
the above header color should complement the main color used in the background images (especially the colors in the top of the background image).
This is my suggestion for the 7 backgrounds in use:
homekit-bg-blue-red.jpg: rgb(30, 2, 61)
homekit-bg-dark-blue.jpg: rgb(48, 69, 124)
homekit-bg-dark-green.jpg: rgb(48, 89, 71)
homekit-bg-light-blue.jpg: rgb(1, 195, 220)
homekit-bg-light-green.jpg: rgb(114, 188, 139)
homekit-bg-orange.jpg: rgb(255, 229, 116)
homekit-bg-red.jpg: rgb(234, 88, 63)

I already changed them manually in my setup, it looks more streamlined than the previous colors.

@basnijholt
Copy link
Owner

Thanks a lot! I have added your suggestions in #44 and released v2.11.0.

I just added 40% transparency.

Let me know what you think!

@okets
Copy link
Author

okets commented Dec 5, 2022

Hi @basnijholt,
I am sorry for the late response. I have been on a long work trip and didn't have a chance to check this.
It looks better with the changes, but as it turns out, the 0.4 changes the color dramatically and therefore creates a distinction between the status bar and the rest of the application.
My point was to create a seamless header that blends with the app.
If you intended for the status bar to be distinct from the rest of the app, leave it as it is, otherwise, just remove the 0.4 opacity and it will blend in.
I forked the theme and changed it manually (it looks awesome in my opinion).
You can see the difference below:
Opacity 1:
3
Opacity 0.4
4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants