Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Remove the logo position filter from header? #103

Closed
bassjobsen opened this issue Feb 5, 2014 · 2 comments
Closed

How to Remove the logo position filter from header? #103

bassjobsen opened this issue Feb 5, 2014 · 2 comments

Comments

@bassjobsen
Copy link
Owner

Questtion from @Linearis

bassjobsen added a commit that referenced this issue Feb 6, 2014
bassjobsen added a commit that referenced this issue Feb 6, 2014
@bassjobsen
Copy link
Owner Author

Thanks for you good and helpful question.
First i found in the source jbst_logo() was a function. In the next update i create a filter for this (and removed the function from library/core.php tp functions/jbst-header-functions.php ).

Now you can remove the logo with:

 add_filter('jbst_logo', function(){return '';});

@bassjobsen
Copy link
Owner Author

In the current situation. One can choose between the logo inside or outside the navbar, with these settings depending of uploaded a logo, the uploaded logo or the brand text is shown.

It seems there should be a setting for no logo at all.
Also the "brand text" should be changeable. The text is now set by get_bloginfo('name'). This should be replaced with a filter.

For future logo change also #98 should be considered again

bassjobsen added a commit that referenced this issue Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant