Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong car model in fleet statistics #545

Open
IMgoRt opened this issue Mar 27, 2021 · 24 comments
Open

Wrong car model in fleet statistics #545

IMgoRt opened this issue Mar 27, 2021 · 24 comments
Labels
bug Something isn't working

Comments

@IMgoRt
Copy link

IMgoRt commented Mar 27, 2021

I have a pre-octovalve Model 3 performance, if you interrogate vehicle_config.trim_badging then the correct value of p74d is returned i.e. 74kWh of usable battery.
If I go to My Degradation" then I'm presented with M3 SR+ a 62kWh battery
The chart for LR would be slightly more appropriate (but still incorrect) as the battery size is the same
A chart for M3 performance is required as the P3D range is less than that of the LR

The same applies to other fleet charts.

The P74D needs to be segmented out in the data harvest as:

  1. its range is skewing other data for vehicles where it is currently allocated
  2. no data is available for the performance model 3

It should be noted that the "2021" performance model 3 has a larger battery and will report a different trim_badging

@IMgoRt IMgoRt added the bug Something isn't working label Mar 27, 2021
@bassmaster187
Copy link
Owner

Could you please send me your Logfile

@IMgoRt
Copy link
Author

IMgoRt commented Mar 27, 2021

Could you please send me your Logfile

This part (the only ref in 3000 lines or send the full logfile where?

27.03.2021 03:30:47 : #2: change TeslaLogger state: GoSleep -> Start

27.03.2021 03:30:47 : #2: Restart communication with Tesla Server! 1
27.03.2021 03:30:47 : #2: ScanMyTesla FastMode: False
27.03.2021 03:30:47 : #2: CloseChargingState()
27.03.2021 03:30:47 : Distance: 3.23418064741338 - Radius: 20 - xxxx
27.03.2021 03:30:47 : Reverse geocoding by Geofence
27.03.2021 03:30:50 : #2: WriteCarSettings -> ModelName: M3 LR eff: 0.152
27.03.2021 03:30:50 : #2: UpdateTeslaToken
27.03.2021 03:30:50 : #2: update tesla_token OK: 1

@bassmaster187
Copy link
Owner

Please send me your whole Logfile to: mail a.t pogea.de

@IMgoRt
Copy link
Author

IMgoRt commented Mar 29, 2021

Please send me your whole Logfile to: mail a.t pogea.de

Done thank you

@bassmaster187
Copy link
Owner

Please update to latest version.
BTW: I'm pretty sure no model 3 is sending anything in trim badge.

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

Please update to latest version.
BTW: I'm pretty sure no model 3 is sending anything in trim badge.

Thanks, all charts now go to M3 LR

The only reason I became aware of trim_badging was in doing PD on the problem - my performance M3 returns p74d in trim_badging

The M3 LR has the same battery as the p74d but the efficiency/range numbers are different, the new performance (with the heat pump/octovalve) comes with a different battery capacity and therefore, I assume, different trim_badging.

@bassmaster187
Copy link
Owner

according to your logfile your car isn't sending any trim badging:
image

only model y are sending p74d or 74d as trim badging:
image

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

according to your logfile your car isn't sending any trim badging:
image

only model y are sending p74d or 74d as trim badging:
image

My own code in nodered returns p74d in response to vehicle

bassmaster187 pushed a commit that referenced this issue Mar 30, 2021
…nextgen

Feature closechargingstate nextgen
@bassmaster187
Copy link
Owner

Could you please send me the raw JSON file of your nodered code?

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

Could you please send me the raw JSON file of your nodered code?

I use https://github.com/mseminatore/TeslaJS so don't get a JSON or do you mean something else - I can provide the object returned unedited

@superfloh247
Copy link
Contributor

you can see the raw JSON that TeslaLogger receives from Tesla:
http://teslalogger:5000/debug/TeslaAPI/1/vehicle_config <-- adjust to your telalogger hostname

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

you can see the raw JSON that TeslaLogger receives from Tesla:
http://teslalogger:5000/debug/TeslaAPI/1/vehicle_config <-- adjust to your telalogger hostname

Hi,
does the 5000 relate to the port I have 80 mapped to on webserver?
if I go to teslalogger:5000 (corrected for my instance) I get the PHP data screen, but adding anything after :5000 gets

Not Found
The requested URL was not found on this server.

Do I need to enable something else for debug or am I targeting the wrong docker container?

@superfloh247
Copy link
Contributor

this is the docker container where TeslaLogger.exe is running

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

this is the docker container where TeslaLogger.exe is running

That was fun:

{"response":{"can_accept_navigation_requests":true,"can_actuate_trunks":true,"car_special_type":"base","car_type":"model3","charge_port_type":"CCS","default_charge_to_max":false,"ece_restrictions":true,"eu_vehicle":true,"exterior_color":"RedMulticoat","exterior_trim":"Chrome","has_air_suspension":false,"has_ludicrous_mode":false,"key_version":2,"motorized_charge_port":true,"plg":false,"rear_seat_heaters":1,"rear_seat_type":null,"rhd":true,"roof_color":"RoofColorGlass","seat_type":null,"spoiler_type":"Passive","sun_roof_installed":null,"third_row_seats":"None","timestamp":1617106231560,"use_range_badging":true,"wheel_type":"Stiletto20DarkSquare"}}

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

this is the docker container where TeslaLogger.exe is running

That was fun:

{"response":{"can_accept_navigation_requests":true,"can_actuate_trunks":true,"car_special_type":"base","car_type":"model3","charge_port_type":"CCS","default_charge_to_max":false,"ece_restrictions":true,"eu_vehicle":true,"exterior_color":"RedMulticoat","exterior_trim":"Chrome","has_air_suspension":false,"has_ludicrous_mode":false,"key_version":2,"motorized_charge_port":true,"plg":false,"rear_seat_heaters":1,"rear_seat_type":null,"rhd":true,"roof_color":"RoofColorGlass","seat_type":null,"spoiler_type":"Passive","sun_roof_installed":null,"third_row_seats":"None","timestamp":1617106231560,"use_range_badging":true,"wheel_type":"Stiletto20DarkSquare"}}

For comparison, here's what teslaJS returns:

{"can_accept_navigation_requests":true,"can_actuate_trunks":true,"car_special_type":"base","car_type":"model3","charge_port_type":"CCS","default_charge_to_max":false,"ece_restrictions":true,"eu_vehicle":true,"exterior_color":"RedMulticoat","exterior_trim":"Chrome","has_air_suspension":false,"has_ludicrous_mode":false,"key_version":2,"motorized_charge_port":true,"plg":false,"rear_seat_heaters":1,"rear_seat_type":null,"rhd":true,"roof_color":"RoofColorGlass","seat_type":null,"spoiler_type":"Passive","sun_roof_installed":null,"third_row_seats":"None","timestamp":1617106280501,"trim_badging":"p74d","use_range_badging":true,"wheel_type":"Stiletto20DarkSquare"}

@bassmaster187
Copy link
Owner

WTF?

@superfloh247
Copy link
Contributor

LOL

@superfloh247
Copy link
Contributor

Model S, TeslaLogger:

{"response":{"can_accept_navigation_requests":true,"can_actuate_trunks":true,"car_special_type":"base","car_type":"models","charge_port_type":"EU","default_charge_to_max":false,"ece_restrictions":true,"eu_vehicle":true,"exterior_color":"Red","has_air_suspension":false,"has_ludicrous_mode":false,"motorized_charge_port":false,"plg":true,"rear_seat_heaters":1,"rear_seat_type":1,"rhd":false,"roof_color":"None","seat_type":1,"spoiler_type":"None","sun_roof_installed":2,"third_row_seats":"None","timestamp":1617086937685,"trim_badging":"85","use_range_badging":false,"wheel_type":"Base19"}}

@IMgoRt
Copy link
Author

IMgoRt commented Mar 30, 2021

I'm being victimised ;-)

@bassmaster187
Copy link
Owner

Ok, very funny...
I am using now the same headers as TeslaJS:

client.DefaultRequestHeaders.Add("x-tesla-user-agent", "TeslaApp/3.4.4-350/fad4a582e/android/8.1.0");
client.DefaultRequestHeaders.Add("User-Agent", "Mozilla/5.0 (Linux; Android 8.1.0; Pixel XL Build/OPM4.171019.021.D1; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/68.0.3440.91 Mobile Safari/537.36");

Now it seems like I've got a trim_badging on a german M3:
image

on a chinese M3 there is still no trim badging, bat eu_vehicle = true altrough it is shipped in China and has chinese charge_port...

image

I have to do now a couple of tests before updating the app as it may change everything.

@bassmaster187
Copy link
Owner

since update yesterday we've got trim badging for model3.
I'll try to investigate if that will help to identifiy models.

@bassmaster187
Copy link
Owner

hmm,
I have a couple of p74d trim badging cars, but they supposed to be non performance according the VIN. So either the vin decoder doesn't work properly or trim badging is wrong.

image

@IMgoRt
Copy link
Author

IMgoRt commented Apr 1, 2021

hmm,
I have a couple of p74d trim badging cars, but they supposed to be non performance according the VIN. So either the vin decoder doesn't work properly or trim badging is wrong.

image

Does the VIN decoder work correctly on mine?

@neredera
Copy link

neredera commented Aug 14, 2021

Hi, I have a base performance from 2019 (Model 3 Performance WITHOUT performance package).
They sold some like this in Q2/Q3 2019.
Teslalogger 1.48.9.0 detects it wrong as a 'M3 LR'.

http://teslalogger:5000/debug/TeslaAPI/1/vehicle_config gives:

{
  "response":
    {
      "can_accept_navigation_requests":true,
      "can_actuate_trunks":true,
      "car_special_type":"base",
      "car_type":"model3",
      "charge_port_type":"CCS",
      "default_charge_to_max":false,
      "driver_assist":"TeslaAP3",
      "ece_restrictions":true,
      "efficiency_package":"Default",
      "eu_vehicle":true,
      "exterior_color":"MidnightSilver",
      "exterior_trim":"Chrome",
      "has_air_suspension":false,
      "has_ludicrous_mode":false,
      "interior_trim_type":"Black",
      "key_version":2,
      "motorized_charge_port":true,
      "performance_package":"Performance",
      "plg":false,
      "rear_drive_unit":"PM216MOSFET",
      "rear_seat_heaters":1,
      "rear_seat_type":null,
      "rhd":false,
      "roof_color":"RoofColorGlass",
      "seat_type":null,
      "spoiler_type":"None",
      "sun_roof_installed":null,
      "third_row_seats":"None",
      "timestamp":1628956500935,
      "trim_badging":"p74d",
      "use_range_badging":true,
      "wheel_type":"Stiletto19"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants