Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basti cleanup not respecting region flag #104

Closed
andreas-mueller-bb opened this issue Aug 5, 2024 · 3 comments
Closed

basti cleanup not respecting region flag #104

andreas-mueller-bb opened this issue Aug 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@andreas-mueller-bb
Copy link

Bug Description

When having multiple setups of basti in different regions such as eu-central-1 and us-west-2 basti cleanup doesn't respect the --aws-region flag when it comes to IAM resources.

Steps to Reproduce

  1. Run basti init --aws-region eu-central-1
  2. Run basti init --aws-region us-west-2
  3. Verify basti is working in both regions & that an IAM role / instance profile exists for each region
  4. Run basti cleanup --aws-region us-west-2

Expected Behavior

After the command in step 4 all basti resources wich were deployed in step 2 should have been removed and all basti resources which were deployed in step 1 should stil be existing.

Current Behavior

Unfortunately basti cleans ALL IAM resources including the role / instance profile that belongs to the eu-central-1 setup wich essentially renders that setup unusable as a connection to the instance via Session Manger is no longer possible.

Possible Solution (Optional)

Somehow make basti aware of the region of the setup which IAM resource belongs to so that basti cleanup does not remove resources which it shouldn't remove.

Apart from that thanks for proving such an elegant solution! :)

@andreas-mueller-bb andreas-mueller-bb added the bug Something isn't working label Aug 5, 2024
@BohdanPetryshyn
Copy link
Collaborator

Hey @andreas-mueller-bb, thanks for reporting this! I'll take a look soon! Meanwhile, would you consider contributing to Basti?

@andreas-mueller-bb
Copy link
Author

Hi @BohdanPetryshyn
I would. But unfortunately I lack the necessary programming skills to do so 😅

@BohdanPetryshyn
Copy link
Collaborator

The issue was resolved in basti@1.6.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants