Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartExplorer Maintainer Wanted discussion & this should be part of Eclipse #64

Closed
paulvi opened this issue Jul 24, 2015 · 29 comments
Closed

Comments

@paulvi
Copy link
Contributor

paulvi commented Jul 24, 2015

This is ticket for discussion.

Frankly I don't think there would be someone to continue. Based on my experience with https://github.com/Nodeclipse/coffeescript-eclipse

The weird thing is that I think there were 1 or 2 similar project starting just within a year, and of course with different names. It looks like new authors did not even tried to search before making new Start/Open/Launch-Explorer/Shell/Cmd/

I have an idea to add all those names into marketplace entry.
Would you please agree to transfer marketplace entry http://marketplace.eclipse.org/content/startexplorer to me or make me maintainer (for marketplace entry only)

Any way I think it is worth trying adding "Maintainer Wanted" on marketplace entry as well.

And one more thing. Why not just contribute it to Eclipse IDE. That would be enormous final release, but StartExplorer is the one that should be standard feature within Eclipse.

@paulvi
Copy link
Contributor Author

paulvi commented Jul 24, 2015

Take a look at Bug 473539 - [TERMINALS] plus StartExplorer = ?

TM Terminals is nice project with Martin Oberhuber always giving response and advise, not to mention great Terminal within Eclipse.

@sleicht
Copy link
Contributor

sleicht commented Sep 9, 2015

I like this project and would be very happy to see it contributed to eclipse. Unfortunately I don't see myself as new maintainer.

@basti1302
Copy link
Collaborator

Adding it to Eclipse so that is a part of an Eclipse distro out of the box in one form or the other would be awesome. I'd totally support this (including necessary changes to enable the transition).

@sleicht maybe you could give vote for it here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=473539

@paulvi
Copy link
Contributor Author

paulvi commented Sep 12, 2015

@sleicht @basti1302 It looks like we need to find proper home for the project. Maybe Eclipse Workbench?

Bug 477259 - Please help find Eclipse project that would help onboard StartExplore project

Maybe @vogella could point in right direction.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 12, 2015

Also there are some Eclipse guru who are active on GitHub

@vrubezhny @dgolovin @mickaelistria @maxandersen @pascalleclercq @gamerson @fbricon @piotrtomiak @jabby

And well, why this can't be Eclipse project on its own, and be hosted on GitHub?

Like https://github.com/eclipse/thym, https://github.com/eclipse/vertx, https://github.com/eclipse/smarthome, https://github.com/eclipse/buildship

@basti1302
Copy link
Collaborator

@paulvi thanks for chiming in. Unfortunately I am pretty clueless about how the various Eclipse projects are structured/organized and how to get this into Eclipse... your help is really appreciated.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 13, 2015

From https://eclipse.org/projects/ then https://wiki.eclipse.org/Development_Resources/HOWTO/Starting_A_New_Project then long questionnaire at https://projects.eclipse.org/node/add/project-proposal

I don't really think that StartExplorer can be Eclipse project on its own (as each Eclipse project should have its own governance, i.e. several people participating), but the asking would definitely bring to the right home.

@vogella
Copy link

vogella commented Sep 14, 2015

If you want contribute code to an existing project, please create Gerrit reviews for it. As there is already a terminal implementation in Eclipse this might be the right place to contribute to. Otherwise it is IMHO perfectly fine to continue to develop a plug-in on Github.

If you are trying to solve the problem that the project is not maintained anymore, the solution is IMHO not to try to contribute it to Eclipse but to find an interested person to maintain it.

@basti1302
Copy link
Collaborator

@vogella Thanks for your input. Makes sense.

@maxandersen
Copy link

I haven't looked at startexplorer for a long time but it is worth noting the following:

  • since Eclipse Kepler (?) there have been a Show In > System Explorer on all resources available in most perspectives.
  • Ctrl+C/Cmd+C for a file already copies the system path for a file (not sure how long that been the case)
  • Open With > Default Editor already exist.

Leaving only "open file in shell" and the various "right click on selected text" actions as unique for startexplorer, afaics ?

Might be worth noting that to whoever wish to continue it.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 14, 2015

I guess Andrey Loskutov @iloveeclipse was one of implementing Show In > System Explorer https://github.com/eclipse/eclipse.platform.ui/commit/3cb4156d96595c957cceb9c58918a84be35cb8b9

@vogella
Copy link

vogella commented Sep 14, 2015

@paulvi You can view the bug behind Andreys commit (or look at the code) and see that this feature existed before. Git history is your friend to see the history of a class

@paulvi
Copy link
Contributor Author

paulvi commented Sep 14, 2015

@vogella #64 (comment)

If you want contribute code to an existing project, please create Gerrit reviews for it.

That is like "spend several hours, but there is no guarantee that someone would need it there"

As there is already a terminal implementation in Eclipse this might be the right place to contribute to.

That is already Bug 473539 - [TERMINALS] plus StartExplorer = ?

There are some use cases (like long running processes), where built-in terminal does not fit yet.
Plus with both installed e.g. in Enide 2015 package user has choice what suits him/her better for the case.

Otherwise it is IMHO perfectly fine to continue to develop a plug-in on Github.

This should be part of Eclipse, see opening comment.

If you are trying to solve the problem that the project is not maintained anymore, the solution is IMHO not to try to contribute it to Eclipse but to find an interested person to maintain it.

This is trick to actually find an interested person to maintain it. :-)

But seriously @basti1302 Bastian has done great work so far, and has no reason to keep it going.
He'd like to spend time and contribute it to Eclipse, the problem is that Eclipse is NOT helping to find suitable place as in Bug 477259 - Please help find Eclipse project that would help onboard StartExplore project

@paulvi
Copy link
Contributor Author

paulvi commented Sep 14, 2015

@maxandersen #64 (comment)

since Eclipse Kepler (?) there have been a Show In > System Explorer

And it still can't be open with one keyboard shortcut, vs Cltr+Alt+E here

1-2 seconds per every use.

Ctrl+C/Cmd+C for a file already copies the system path for a file

only short file/folder name (). There is also Copy qualified name without shortcut, but the path is relative to workspace

With this plugin Eclipse is in equals to IDEA

image

or actually better

image

Open With > Default Editor already exist.

Open with (System Editor) has history, and will remember that and will use System Editor next time vs Cltr+Alt+A for whatever editor was used before.

1-2 seconds per every use.

well, should Eclipse be caring to save seconds for every of its user?

Possibly this project should be next to external tools.

image

They are not have clicked file concept.

@maxandersen
Copy link

@paulvi you seem to be asking the wrong question. Instead of asking about where to put the system explorer project, then open the above as bugs in the platform to get fixed and try find someone to get it fixed/improved.

If you want system explorer to continue as is and just be as it is now then it is a project on its own - not something to force push into Platform UI as a big block.

@maxandersen
Copy link

@maxandersen #64 (comment)

since Eclipse Kepler (?) there have been a Show In > System Explorer

And it still can't be open with one keyboard shortcut, vs Cltr+Alt+E here

I just tried and I could assign Ctrl+Alt+E in shortcuts preferences just fine.
If you want a default keyboard shortcut open a bug for that.

btw. I stopped using keyboard shortcuts for specific stuff like this since I can just use Cmd+3 "system" to do it from anywhere.

Ctrl+C/Cmd+C for a file already copies the system path for a file

only short file/folder name (). There is also Copy qualified name without shortcut, but the path is relative to workspace

That is not what I see. I select a resource, press Ctrl+C and I have a full path of the file.

And yes, I can assign Copy qualified name to a shortcut too.

The only thing I see missing is the copy single name, but that does not seem to be a crucial thing IMO.

But open a bug for that one thing missing.

Open With > Default Editor already exist.

Open with (System Editor) has history, and will remember that and will use System Editor next time vs Cltr+Alt+A for whatever editor was used before.

Okey, I don't personal see much use for it but again, sounds like something that should be fixed at the platform level rather than adding yet another duplicated mechanism.

well, should Eclipse be caring to save seconds for every of its user?

of course - and it does.

Possibly this project should be next to external tools.

I don't see how - maybe the very specific sub-feature of launching a shell could fit here.

image

They are not have clicked file concept.

there are http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fdebug_launch_uishortcuts.htm which can generate launch proposals based on current selection which could be used to generate launches running the appropriate shell/terminal as a launch.

So again, for me this does not look like "where should systemexplorer be hosted at eclpse" more a "how can the features in system explorer get integrated with the platform".

And i'm happy to help figuring that out but I can't help implement it.

@jmini
Copy link

jmini commented Sep 15, 2015

So again, for me this does not look like "where should systemexplorer be hosted at eclpse" more a "how can the features in system explorer get integrated with the platform".

And i'm happy to help figuring that out but I can't help implement it.

On the long term this is probably the way to go.

In the meantime a lot of users are happy with the features as they are offered, implemented and displayed by the SmartExplorer plugin.

This discussion shows that there is a feature overlapping, but not 100% and not with the same user experience.

The comment from @maxandersen on Bugzilla (477259#c8) makes sense:

I think trying to bulk move startexplorer into eclipse is not the right path.


Could not be eclipselabs on GitHub (see Bug 462286) a new home for this codebase?

With some colleagues, we are trying to figure out what needs to be done:

This way we obtain something more sustainable for this plugin.


This plan is not incompatible with improving the Eclipse platform (improving it to offer the same functionalities). The long time vision could be that when the features are moved or implemented into the Eclipse platform, the SmartEdit plugin will only be about presentation and user experience (adding the desired shortcuts, adding menus to call the platform actions…). At the end the code base of the SmartExplorer plugin should be reduced.

@mickaelistria
Copy link

since Eclipse Kepler (?) there have been a Show In > System Explorer

And it still can't be open with one keyboard shortcut, vs Cltr+Alt+E here

I just tried and I could assign Ctrl+Alt+E in shortcuts preferences just fine.
If you want a default keyboard shortcut open a bug for that.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=477451
Trivial fix in progress.

@paulvi paulvi changed the title Maintainer Wanted discussion Maintainer Wanted discussion & this should be part of Eclipse Sep 16, 2015
@paulvi
Copy link
Contributor Author

paulvi commented Sep 16, 2015

There should have been a few separate issue discussion forked from here, please create

@ all Giving a wider context

Eclipse has got built-in Terminal, launched via Cltr+Alt+T

There is also eExplorer (embedded Explorer) #52 by Matthias @culmat (no quick shortcut yet, please vote 👍 for Ctrl+Alt+Shift+E culmat/eExplorer#37)
I think there exists something for MacOS as welll

Terminal, Terminal and StartExploer are related and should be more integrated.
E.g. using Show in Alt+Shift+W
or Run External Tool. External tools are in Run menu and in ToolBar, but not in context menu.

image

image

That is why StartExplorer can be part of some bigger future project.
When there's only one person developing then what Jérémie described is likely smart way.

@jmini #64 (comment)

with-Eclipse logo

@paulvi paulvi changed the title Maintainer Wanted discussion & this should be part of Eclipse StartExplorer Maintainer Wanted discussion & this should be part of Eclipse Sep 16, 2015
@basti1302
Copy link
Collaborator

I wrote some things about the "integrate parts of StartExplorer into the Eclipse UI" at https://bugs.eclipse.org/bugs/show_bug.cgi?id=477259#c12

Summary: Some good ideas, let's see how they work out. As a fallback, if nothing comes out of it, the current status quo is also okay. As said before, I still do bug fixes from time to time and merge PRs. I just will not put a lot of effort into StartExplorer anymore.

Regarding Tycho and Travis build: Yes, Paul added them a while back. Since I was the only person building and publishing this project and they added more hassle than benefit for me, I threw them out eventually but they can easily be resurrected from the git history.

@vogella
Copy link

vogella commented Sep 18, 2015

I think a good starting point for any contribution is to remove the bits which are already in Eclipse standard.

@maxandersen
Copy link

@paulvi it is called Run External Tools, not just "Run Tools" and already exist. Just need to have some launch detectors that set it up afaics.

@paulvi
Copy link
Contributor Author

paulvi commented Sep 22, 2015

@maxandersen #64 (comment)

yes, "Run External Tools"

@mickaelistria
Copy link

The shortcut for opening system explorer is now provided by platform UI: https://bugs.eclipse.org/bugs/show_bug.cgi?id=477451

@fabioz
Copy link
Owner

fabioz commented Jan 30, 2016

Closing this bug. After seeing the helpwanted on the readme I volunteered with Bastian and he has passed the project over to me -- I must say I only really acknowledged this issue now ;)

My plan is mostly keeping the current status quo of the project (which means I'll keep the project running / integrating fixes and fixing some things myself, although I don't expect to expand on the current focus of the plugin, which does work pretty well on my view -- and I use it daily anyways).

Regarding duplicate functionality from the platform, it's possible that I'll trim some of that in the future and point users to the Eclipse version if it's a better alternative -- although the open explorer itself is probably going to remain there even if only to have a default keybinding and to appear in the StartExplorer menu (this is the may point of this plugin after all)... also, I have nothing against having code copied from here to Eclipse (quite the contrary -- and the license definitely allows it), but I probably won't be doing that work myself.

To finish, there were many different threads on this issue, so, please open new issues if you think they're worth it ;)

@fabioz fabioz closed this as completed Jan 30, 2016
@basti1302
Copy link
Collaborator

I totally forgot to report back here, but full ack on what @fabioz said. I think him taking over is really the ideal outcome. The plans to put parts of this into Eclipse core might have been a nice idea, it just never happened and nobody was pushing it enough.

@paulvi
Copy link
Contributor Author

paulvi commented Jan 31, 2016

Huray! Welcome @fabioz Fabio here

@mickaelistria
Copy link

Thanks @fabioz and @basti1302 .
Using the same shortcut for this operation in Eclipse Platform was a failure: https://bugs.eclipse.org/bugs/show_bug.cgi?id=477451#c10 . We can keep discussing of finding a better one for Eclipse Platform, and you opinion on that would be welcome on the bug.
If there is anything that you believe would be a good candidate for being in Eclipse Platform,just bring the topic on the platform-ui-dev@eclipse.org mailing-list, and we'll be pleased to collaborate with you in order to factorize good pieces of functionality and to deliver more value to more users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants