-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matlab indentation check #2
Conversation
Thank you for this contribution. Is there a particular reason that you moved the list of keywords etc. to the settings file? Why would the user need to customize these? I very much like your test file. I should definitely add more of those. They should probably live in a separate package, though. |
I don't think, that the user would customize the keywords, but I was looking for only one place, where to define all these keywords and I didn't want to use an additional file. Otherwise it is necessary to change 3 files ( tokenize_code.m check.m analyze_file.m) to add keywords like for the try catch block. One could even consider to use matlabs Moving test files to a separate package is a good idea - imho. |
Resolve "Fix matlab identation check" Closes bastibe#2 See merge request !2
…ve expected behavior
Sorry I forgot about your pull request. Is this ready to be merged, in your opinion? It looks good to me. |
I just found this repository and have gotten a ton of mileage from the function! But I did notice that the |
I'm on vacation right now, and can't check if this pull request is ready to be merged. If anyone could have a look, I'd be grateful! |
It looks like @bertramr's fix works well up until 2019a. I am getting an error with the |
My apologies - for clarification, the |
Thank you very much! |
The indentation check for try catch block didn't work as expected.
Following example files should show the problem.
With adding
try
catch
as keywords, beginnings and middles this should be solved.However the checker doesn't find the documentation string. Probably due to the access properties.