-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f-strings #21
Comments
Is this the only problem with 3.4 compatibility? Would you want to create a pull request? |
@bastibe no, actually 1_000_000 is a syntax error in py3.5.2, too. I try to get it to work... 😐 |
I'll look forward to your pull request. |
I believe that once the new version is published on pypi, this can be closed, since f-strings were removed for 3.5 compatibility in #46 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
f-strings are quite a new thing and machines without the latest python (3.5 is close, but not enough...) will not be able to use this. I think it would be great to change those 6 occurrences of them to ˋ''.format()ˋ which has better support. Also, you are not using fancy formats, so why stick to f-strings while excluding older versions...?
file: lines
test_soundcard.py: 43, 61
mediafoundation.py: 196, 220, 380, 410
The text was updated successfully, but these errors were encountered: