Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-strings #21

Closed
ep12 opened this issue Jul 26, 2018 · 4 comments
Closed

f-strings #21

ep12 opened this issue Jul 26, 2018 · 4 comments

Comments

@ep12
Copy link

ep12 commented Jul 26, 2018

f-strings are quite a new thing and machines without the latest python (3.5 is close, but not enough...) will not be able to use this. I think it would be great to change those 6 occurrences of them to ˋ''.format()ˋ which has better support. Also, you are not using fancy formats, so why stick to f-strings while excluding older versions...?

file: lines
test_soundcard.py: 43, 61
mediafoundation.py: 196, 220, 380, 410

@bastibe
Copy link
Owner

bastibe commented Jul 29, 2018

Is this the only problem with 3.4 compatibility?

Would you want to create a pull request?

@ep12
Copy link
Author

ep12 commented Aug 5, 2018

@bastibe no, actually 1_000_000 is a syntax error in py3.5.2, too. I try to get it to work... 😐

@bastibe
Copy link
Owner

bastibe commented Aug 5, 2018

I'll look forward to your pull request.

@dkumor
Copy link
Contributor

dkumor commented Mar 21, 2019

I believe that once the new version is published on pypi, this can be closed, since f-strings were removed for 3.5 compatibility in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants