fix setup script, port to Lua 5.2 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- type luaL_reg is now luaL_Reg - define LUA_COMPAT_ALL or LUA_COMPAT_MODULE to enable some deprecated features This still builds with Lua 5.1. It doesn't yet build with 5.2, but it's closer than it was.
This is less code, and it works with Lua 5.1 and 5.2 as well. (The old code, using LUA_GLOBALINDEX, does not work with 5.2.)
It's been out for just over a year now, since Dec 2011. Lua 5.1 is over six years old (Feb 2006).
bastibe
added a commit
that referenced
this pull request
Feb 21, 2013
fix setup script, port to Lua 5.2
|
Seems to work fine on OSX, too. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now it builds cleanly on Ubuntu 12.10 if you install "lua5.1" and "liblua5.1-dev"
(before these patches, it crashed badly and unclearly, by interpreting pkg-config's error message as meaningful output: not good)
and it works with both Lua 5.1 and 5.2!