Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transplant crippled on msgpack-python 0.6.0 (max_bin_len change) #67

Closed
jooh opened this issue Jan 16, 2019 · 3 comments
Closed

transplant crippled on msgpack-python 0.6.0 (max_bin_len change) #67

jooh opened this issue Jan 16, 2019 · 3 comments

Comments

@jooh
Copy link
Contributor

jooh commented Jan 16, 2019

Thanks for a great tool. Transplant crashes on large matlab variables when installed with msgpack 0.6.0 due to a change to the max_bin_len default. See also related issue on spacy here.

Downgrading to msgpack-python 0.5.6 fixed it for me. A quick fix would be to pin to <= 0.5.6.
@bastibe
Copy link
Owner

bastibe commented Jan 17, 2019

Thank you for raising awareness for this issue! I was unaware of this, but apparently many people are angry about this change!

Can you check if #68 fixes this issue?

@jooh
Copy link
Contributor Author

jooh commented Jan 17, 2019

Yup, that works for me under msgpack 0.6.0! Thanks for the quick response.

@bastibe
Copy link
Owner

bastibe commented Jan 17, 2019

Cool!

@bastibe bastibe closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bastibe @jooh