Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather service #180

Closed
Baitinq opened this issue Jan 10, 2021 · 5 comments · Fixed by #181
Closed

Weather service #180

Baitinq opened this issue Jan 10, 2021 · 5 comments · Fixed by #181
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Baitinq
Copy link

Baitinq commented Jan 10, 2021

It would be really cool if there was a weather service in homer. I might get around implementing it one of these days but if anyone else has one already and is willing to share it would be extremely cool!

@dickwolff
Copy link
Contributor

dickwolff commented Jan 12, 2021

I was also looking for this and since there wasn't anything yet I went on to create something myself. See the image below. Is this something you were looking for also?

image

I used the OpenWeatherMap API and added a few configuration options (like api key, location, units). The image is retrieved from OWM based on the image code (per documentation). The resulting yml is:

image

@bastienwirtz bastienwirtz added enhancement New feature or request good first issue Good for newcomers labels Jan 13, 2021
@bastienwirtz
Copy link
Owner

Hello!

Nice idea!
@dickwolff would you be open to share your implementation by submitting a PR to add the custom service to the collection?

@dickwolff
Copy link
Contributor

Yeah sure! I'll open a PR and link this issue.

@dickwolff
Copy link
Contributor

dickwolff commented Jan 13, 2021

I've created an initial PR. Need to finish up some checks and I have one question about the URL which I would like your opinion on @bastienwirtz

Edit: I took the liberty to make the URL fixed myself. Since this doesn't change and it doesn't need to, there was no reason to make it configurable.

@Baitinq
Copy link
Author

Baitinq commented Jan 24, 2021

@dickwolff this is exactly what i was looking for. Thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants