Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding full off network support. #11

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Adding full off network support. #11

merged 3 commits into from
Jan 14, 2020

Conversation

bastienwirtz
Copy link
Owner

Related to #9.
Copy all external resources locally to make it usable full offline.

@fbartels
Copy link
Contributor

Hi, thanks. Looks quite a bit better now. Sometimes a picture amounts for a thousand words:

Screenshot 2020-01-13 at 08 22 25

When switching Chrome to offline after a first normal request then it almost looks good, only the image above the "You're offline bro" is missing.

Screenshot 2020-01-13 at 08 22 45

When now doing a forced reload however (ctrl+shift+r) some more resources go missing. Not quite sure if this can be labeled as expected behaviour, but then it would still be strange that other resources survive this treatment.

@bastienwirtz
Copy link
Owner Author

My bad, I forgot the additional font awesome files in the service worker, it should be better now!

@fbartels
Copy link
Contributor

Thanks again. Now the only resources throwing errors are the ?alive request (which I would label as expected) and the favicon.png request.

@bastienwirtz
Copy link
Owner Author

Good catch, the favicon was missing too. Thanks to you to contribute and taking some time to test it!
Have a nice day !

@bastienwirtz bastienwirtz merged commit 250c67d into master Jan 14, 2020
@bastienwirtz bastienwirtz deleted the everything-offline branch January 14, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants