-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Feature to Hide the Header #26
Conversation
Thanks again for your contribution @traeblain! There is a Does the simple |
I checked again. I thought if I agree the simplest approach (and aligning with your KISS mentality with this whole thing) is to simply have This should do it...although not sure how clean you want the git history. (My git skills for clean merges aren't very good.) |
/ starts searching. Escape clears the search terms.
29467a3
to
c6f1f77
Compare
Hope I rebased this properly...the change is so simple, if I need to dump it for a new one let me know... Honestly, probably didn't do it right... |
Hey @traeblain |
This allows the header to be set as
false
and therefore hiding the header but still having the data liketitle
andsubtitle
.Addresses part 1 of #21
Object.assign
Used Object.assign to default the
header
property to true. Right now it is inline, but I could see if you wanted to have some set of default settings in an object then merge the two, that could be done. It's up to you.Did not set this in the data.config to start with because it would 1) initiate the app at all times since there's a
v-if
on that template portion. 2) I don't recall if Vue reactivity is triggered with Object.assign.