Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Proxmox Custom Service #525

Merged
merged 4 commits into from Oct 13, 2022
Merged

Improves Proxmox Custom Service #525

merged 4 commits into from Oct 13, 2022

Conversation

luixal
Copy link
Contributor

@luixal luixal commented Oct 11, 2022

Description

As users started using the Proxmox custom service, some improvements came up and are included in this PR:

  • Avoid showing zeroed values: while loading, default values (0) where shown. No a loading message is shown.
  • Iconography: icons added to show states (loading and error) on the indicator slot.
  • Documentation: some info about permissions needed in proxmox. Also added a comment on possible CORS problem.

Fixes #520

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit f5114e7
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/634733fad6600900083c1992
😎 Deploy Preview https://deploy-preview-525--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@tobidemski tobidemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm expect the little typo

docs/customservices.md Outdated Show resolved Hide resolved
@bastienwirtz bastienwirtz merged commit 96da0c7 into bastienwirtz:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2x Custom Services Do Not Work
3 participants