Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'method' not defaulting to HEAD request in Ping functionality #532

Merged
merged 1 commit into from Oct 16, 2022
Merged

Fixed 'method' not defaulting to HEAD request in Ping functionality #532

merged 1 commit into from Oct 16, 2022

Conversation

Lorthiz
Copy link
Contributor

@Lorthiz Lorthiz commented Oct 15, 2022

Description

In the documentation it is pointed out that method "HEAD" should be used as default method for PING, but it was defaulting to 'unknown'

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@netlify
Copy link

netlify bot commented Oct 15, 2022

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit c5aeaec
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/634ad0339385500009d1d073
😎 Deploy Preview https://deploy-preview-532--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey good catch. Thanks for contributing!

@bastienwirtz bastienwirtz merged commit 956f38a into bastienwirtz:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants