Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve grammar of offline message #736

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

librick
Copy link
Contributor

@librick librick commented Jan 13, 2024

Description

The message that appears when Homer is offline implies that the developers of Homer consider me to be their offline friend. I believe the intent of the message is to communicate that I am simultaneously offline and considered by Homer's developers to be a friend.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit e3514d9
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/65a21526fabffb000814eb41
😎 Deploy Preview https://deploy-preview-736--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@bastienwirtz bastienwirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better indeed! Thanks @librick !

@bastienwirtz bastienwirtz merged commit 5f5a508 into bastienwirtz:main Mar 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants