Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extreme amount of syscalls to give time share to OS #147

Merged
merged 4 commits into from Dec 31, 2019
Merged

Fix extreme amount of syscalls to give time share to OS #147

merged 4 commits into from Dec 31, 2019

Conversation

vertexclique
Copy link
Member

No description provided.

@rtyler
Copy link

rtyler commented Dec 31, 2019

As mentioned in DIscord, this commit does remove the syscall storm to sched_yield under the covers, but it does not remove the CPU-intensive busy-loop that is happening here.

@rtyler rtyler mentioned this pull request Dec 31, 2019
Closed
@rtyler
Copy link

rtyler commented Dec 31, 2019

with the change in 03b2dbc, this is looking good 👍

@r3v2d0g
Copy link
Contributor

r3v2d0g commented Dec 31, 2019

I updated Bastion::block_until_stopped to use a Condvar which should have near to zero CPU costs :)

@vertexclique vertexclique merged commit 957258f into master Dec 31, 2019
@vertexclique vertexclique deleted the thread-yield-overburden-fix branch December 31, 2019 15:18
@vertexclique
Copy link
Member Author

Fixes #148 completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3v2d0g r3v2d0g r3v2d0g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vertexclique @rtyler @r3v2d0g