-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscaling actor groups in runtime #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relrin
force-pushed
the
feature-autoresize-actor-groups
branch
from
May 15, 2020 15:50
04defc6
to
3c15e3b
Compare
Relrin
force-pushed
the
feature-autoresize-actor-groups
branch
from
June 8, 2020 21:53
aa37de3
to
4ff0734
Compare
Relrin
force-pushed
the
feature-autoresize-actor-groups
branch
from
July 17, 2020 19:24
bba2972
to
de74b0c
Compare
Relrin
force-pushed
the
feature-autoresize-actor-groups
branch
from
July 17, 2020 20:47
de74b0c
to
cab503a
Compare
vertexclique
approved these changes
Jul 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is state of the art. Just ornamental things. The rest is looking amazing. Awesome work. Thanks.
o0Ignition0o
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the part of this PR, I would to introduce the changes that cover needs in autoscaling actor groups in runtime. The initiative was described in the #155 issue.
The idea
Before starting with the example, any developers needs to enable the
scaling
feature flag which using for getting an access to desired API, collecting statistical information from actors, etc.Then, we can import the resizer, and declare the rules around how much actors acceptable (minimal, maximum) for the each actor group. It will be look something like this:
The resizers will take care about reacting on collected stats (currently: active actors and the average mailbox size) and will ask a Child instance to scale up or down the actor group when it necessary in runtime.
Checklist
cargo test
.