Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor work #53

Merged
merged 41 commits into from Nov 6, 2019
Merged

Executor work #53

merged 41 commits into from Nov 6, 2019

Conversation

vertexclique
Copy link
Member

@vertexclique vertexclique commented Oct 26, 2019

@vertexclique vertexclique self-assigned this Oct 26, 2019
Comment on lines 11 to 15
#![feature(extern_types)]
#![feature(core_intrinsics)]
#![feature(libstd_sys_internals)]
#![feature(thread_local)]
#![feature(const_fn)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed ;)

Comment on lines +167 to +170
#[cfg(target_os = "windows")]
extern crate kernel32;
#[cfg(target_os = "windows")]
extern crate winapi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably be removed

bastion-executor/src/pool.rs Show resolved Hide resolved
Comment on lines 37 to 39
let future = async move {
future.await;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed ;)

Comment on lines 34 to 35
// Wrap the future into one that drops task-local variables on exit.
// let future = task_local::add_finalizer(future);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed? :)

@@ -0,0 +1 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file's empty ;)

let mut stealers = Vec::<Stealer<LightProc>>::new();

for core in self.cores {
self.round = core.id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distributor.round doesn't seem to be used anywhere else

bastion-executor/src/blocking_pool.rs Outdated Show resolved Hide resolved
@vertexclique
Copy link
Member Author

vertexclique commented Nov 5, 2019

We are approximately ready to glue bastion + bastion-executor + lightproc.
This is going in for now!

@vertexclique vertexclique merged commit ccdeb15 into dev Nov 6, 2019
@vertexclique vertexclique deleted the executor-work branch November 6, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants