Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing f-string Specifier in PhononWorkChain #61

Closed
eric-read opened this issue Mar 24, 2024 · 3 comments · Fixed by #63
Closed

Missing f-string Specifier in PhononWorkChain #61

eric-read opened this issue Mar 24, 2024 · 3 comments · Fixed by #63

Comments

@eric-read
Copy link

eric-read commented Mar 24, 2024 •
edited
Loading

In PhononWorkChain in the inspect_all_runs method there is a missing f-string specifier on line 454
that is causing the workchain to not report what the exit status for the subprocess that failed.
'with exit status {workchain.exit_status}' should be f'with exit status {workchain.exit_status}'
@bastonero
Copy link
Owner

Hello, in the main release of the code we don't have such WorkChain. I suppose you are referring to an Environ implementation, is it correct? I know a collaborator of mine that is working on this, but as you can inspect there's yet not official support.

@eric-read
Copy link
Author

eric-read commented Mar 24, 2024 •
edited
Loading

My mistake, I meant PhononWorkChain I made a modified version that uses Environ. Editted issue to correct the mistake.

@eric-read eric-read changed the title Missing f-string Specifier in EnvPhononWorkChain Missing f-string Specifier in PhononWorkChain Mar 24, 2024
bastonero added a commit that referenced this issue Mar 24, 2024
@bastonero
Fix some docstrings and reports
742b1c1 
Fixes #61

The PhononWorkChain was missing an 'f' string, thus missing
to report the `exit_status` of possible failed child WorkChains.
The DielectricWorkChain had the `property` input badly documented.
@bastonero
Copy link
Owner

Thanks for reporting this. I am about to open a PR to fix this.

@bastonero bastonero mentioned this issue Mar 24, 2024
Merged
bastonero added a commit that referenced this issue Mar 24, 2024
@bastonero
Fix some docstrings and reports (#63)
3ee9e7c 
Fixes #61

The PhononWorkChain was missing an 'f' string, thus missing
to report the `exit_status` of possible failed child WorkChains.
The DielectricWorkChain had the `property` input badly documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some docstrings and reports bastonero/aiida-vibroscopy
2 participants
@eric-read @bastonero