Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Add filterPlaceholder input #124

Closed
wants to merge 1 commit into from
Closed

Add filterPlaceholder input #124

wants to merge 1 commit into from

Conversation

Crevil
Copy link
Contributor

@Crevil Crevil commented Feb 23, 2017

This PR closes #121

Additions

  • filterPlaceholder input to allow setting the filter input placeholder
  • Sample on demo application
  • Feature to vNEXT in changelog
  • Input to README component input list

Changes

  • It seems the line endings have been changed on select-dropdown.component.ts, I've only added line 37 (@Input() placeholder: string)
  • Changed tabs to spaces for OPTIONS_MANY

@basvandenberg
Copy link
Owner

Thanks for the contribution, I guess this only applies to the single select case, right?

Since there are quit a few changes I'll have a look at it later this week.

@Crevil
Copy link
Contributor Author

Crevil commented Feb 26, 2017

Yeah, gotta admit that I havent checked out the multi selection mode, so it properbly is.

Sure thing, glad to help out and thanks for the project. If you'd like it, I'd gladly help out with further developments, just let me know.

@basvandenberg
Copy link
Owner

Thanks again @Crevil! Great work, even added an example, very nice. Your pull request has been merged into the beta.4 branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants