Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings / General #28

Closed
3 of 4 tasks
frederikbugglin opened this issue Mar 16, 2021 · 3 comments
Closed
3 of 4 tasks

Settings / General #28

frederikbugglin opened this issue Mar 16, 2021 · 3 comments
Assignees

Comments

@frederikbugglin
Copy link
Contributor

frederikbugglin commented Mar 16, 2021

  • Remove form field "Typ"
  • Change current field names according to design
  • max. column width = span? 6 cols
  • Optional: Add logo upload functionality (for branding purposes, e.g. used in ui shell header or for future PDF-Reports, etc.)

Allgemein

Bildschirmfoto 2021-03-16 um 14 56 32

@saemideluxe
Copy link
Member

The grid-defintions in the carbon design CSS only define the flexible grid, not the fixed grid. I assume the 6 columns refer to fixed-sized columns? Since the CSS definitions are not really clear about that (or I do not yet parse it correctly), I will assume one column to be 10 mini units (8px). And therefore setting the max-width to 480px (8px * 10 * 6). It looks correct

@saemideluxe
Copy link
Member

The "optional" is not done yet, I wonder whether we should add the "logo/profile picture" field to all persons? If not I will just a single one, if yes I suggest we open a new issue in order to track the progress on that.

@frederikbugglin
Copy link
Contributor Author

Add a single upload logo component to Settings/General as shown above. And See issue #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants