Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper propTypes with properTypes #8

Merged
merged 2 commits into from
May 16, 2018
Merged

proper propTypes with properTypes #8

merged 2 commits into from
May 16, 2018

Conversation

magic-m-johnson
Copy link
Contributor

funnily enought, properTypes come in the correct format to be compatible with the rest of the FixtureEditor.

OMG It's intuitive! 😱

@magic-m-johnson
Copy link
Contributor Author

no idea why the travis script fails... npm test works, npm dist doesn't. Same behavior on local env. yarn dist works.... th?

Deschtex
Deschtex approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@Deschtex Deschtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magic-m-johnson magic-m-johnson merged commit 9d19126 into master May 16, 2018
@Deschtex Deschtex mentioned this pull request May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deschtex Deschtex Deschtex approved these changes

@deepsweet deepsweet Awaiting requested review from deepsweet

@xaviervia xaviervia Awaiting requested review from xaviervia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magic-m-johnson @Deschtex