Fix #65.

The Docker daemon seems to have a race condition where it can report a 'bad file descriptor' error when trying to resize a container that has just stopped.
batect · Feb 14, 2019 · f9a3084 · f9a3084
1 parent d257ef3
commit f9a3084
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/app/src/main/kotlin/batect/docker/DockerAPI.kt b/app/src/main/kotlin/batect/docker/DockerAPI.kt
@@ -460,6 +460,10 @@ class DockerAPI(
                     throw ContainerStoppedException(message)
                 }
 
+                if (error.statusCode == 500 && error.message.trim() == "bad file descriptor: unknown") {
+                    throw ContainerStoppedException("$message (the container may have stopped quickly after starting)")
+                }
+
                 throw DockerException(message)
             }
         }

diff --git a/app/src/test/kotlin/batect/docker/DockerAPISpec.kt b/app/src/test/kotlin/batect/docker/DockerAPISpec.kt
@@ -574,6 +574,14 @@ object DockerAPISpec : Spek({
                     }
                 }
 
+                on("the container being stopped and the daemon returning a 'bad file descriptor' error") {
+                    httpClient.mockPost(expectedUrl, """{"message": "bad file descriptor: unknown"}""", 500)
+
+                    it("throws an appropriate exception") {
+                        assertThat({ api.resizeContainerTTY(container, dimensions) }, throws<ContainerStoppedException>(withMessage("Resizing TTY for container 'the-container-id' failed: bad file descriptor: unknown (the container may have stopped quickly after starting)")))
+                    }
+                }
+
                 on("the API call failing") {
                     httpClient.mockPost(expectedUrl, """{"message": "Something went wrong."}""", 418)