Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions CI #26

Merged
merged 1 commit into from
May 9, 2023
Merged

Update GitHub Actions CI #26

merged 1 commit into from
May 9, 2023

Conversation

striezel
Copy link
Contributor

The following updates are performed:

Still using the outdated / unmaintained actions will generate several warnings in CI runs, for example in https://github.com/nanaian/merlon/actions/runs/4840585499:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The PR will get rid of those warnings.

@bates64 bates64 force-pushed the main branch 3 times, most recently from ba25550 to c21f3d9 Compare April 30, 2023 10:45
@bates64 bates64 self-requested a review April 30, 2023 11:35
Copy link
Owner

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good, but this workflow file has changed a lot since. Could you resolve the merge issues?

The following updates are performed:
* update actions/checkout to v3
* replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain
* replace unmaintained actions-rs/cargo by direct invocations of cargo
@striezel
Copy link
Contributor Author

striezel commented May 9, 2023

@nanaian

Could you resolve the merge issues?

Done and force-pushed to the branch. :)

@bates64 bates64 merged commit 64dcf97 into bates64:main May 9, 2023
11 checks passed
@striezel striezel deleted the ci-actions-update branch May 9, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants