Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix install command #47

Merged
merged 3 commits into from
Jun 26, 2023
Merged

fix install command #47

merged 3 commits into from
Jun 26, 2023

Conversation

Wrymouth
Copy link
Contributor

No description provided.

@Wrymouth Wrymouth marked this pull request as ready for review June 26, 2023 16:09
bates64
bates64 requested changes Jun 26, 2023
View reviewed changes
Copy link
Owner

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Ideally we wouldn't break support for older versions of decomp before this change was made. Can you add a check to see if a install.sh file exists, and if so, run that instead of these two?

src/package/init.rs Outdated Show resolved Hide resolved
@bates64
Copy link
Owner

bates64 commented Jun 26, 2023

This bug introduced by pmret/papermario@8837fbd

Wrymouth and others added 2 commits June 26, 2023 18:27
bates64
bates64 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Owner

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks - I should be running rustfmt anyway so the formatting changes are NBD. Can you verify that tests pass (cargo test)?

@Wrymouth
Copy link
Contributor Author

single_dependency appears to fail

@bates64
Copy link
Owner

bates64 commented Jun 26, 2023

That's fine, it fails on main too 🤪

@bates64 bates64 merged commit ebf010c into bates64:main Jun 26, 2023
11 checks passed
@Wrymouth Wrymouth deleted the fix-install branch June 27, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bates64 bates64 bates64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PM mod tooling
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wrymouth @bates64