add test lost in the merge

batfish · Feb 19, 2021 · c5db23f · c5db23f
1 parent c5d09bb
commit c5db23f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java b/projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java
@@ -4861,6 +4861,7 @@ public void exitPopsf_interface(Popsf_interfaceContext ctx) {
 
   @Override
   public void exitPopsf_local_preference(Popsf_local_preferenceContext ctx) {
+    todo(ctx.getParent());
     _currentPsTerm
         .getFroms()
         .setFromLocalPreference(new PsFromLocalPreference(toLong(ctx.localpref)));

diff --git a/projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java b/projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java
@@ -353,6 +353,7 @@
 import org.batfish.representation.juniper.NoPortTranslation;
 import org.batfish.representation.juniper.PatPool;
 import org.batfish.representation.juniper.PolicyStatement;
+import org.batfish.representation.juniper.PsFromLocalPreference;
 import org.batfish.representation.juniper.PsThenLocalPreference;
 import org.batfish.representation.juniper.PsThenLocalPreference.Operator;
 import org.batfish.representation.juniper.RoutingInstance;
@@ -3534,6 +3535,22 @@ public void testJuniperPolicyStatementPrefixListDisjunction() {
     assertThat(result.getBooleanValue(), equalTo(false));
   }
 
+  @Test
+  public void testJuniperPolicyStatementTermFromExtraction() {
+    JuniperConfiguration c = parseJuniperConfig("juniper-policy-statement-from");
+    {
+      PolicyStatement policy =
+          c.getMasterLogicalSystem().getPolicyStatements().get("LOCAL_PREFERENCE_POLICY");
+      assertThat(policy.getTerms(), hasKeys("TMIN", "TMAX"));
+      assertThat(
+          policy.getTerms().get("TMIN").getFroms().getFromLocalPreference(),
+          equalTo(new PsFromLocalPreference(0)));
+      assertThat(
+          policy.getTerms().get("TMAX").getFroms().getFromLocalPreference(),
+          equalTo(new PsFromLocalPreference(MAX_LOCAL_PREFERENCE)));
+    }
+  }
+
   @Test
   public void testJuniperPolicyStatementTermThenExtraction() {
     JuniperConfiguration c = parseJuniperConfig("juniper-policy-statement-then");

diff --git a/.../src/test/resources/org/batfish/grammar/juniper/testconfigs/juniper-policy-statement-from b/.../src/test/resources/org/batfish/grammar/juniper/testconfigs/juniper-policy-statement-from
@@ -0,0 +1,6 @@
+#
+set system host-name juniper-policy-statement-from
+#
+set policy-options policy-statement LOCAL_PREFERENCE_POLICY term TMIN from local-preference 0
+set policy-options policy-statement LOCAL_PREFERENCE_POLICY term TMAX from local-preference 4294967295
+#