review

batfish · Jan 15, 2021 · cfb9e78 · cfb9e78
1 parent cfa9e38
commit cfb9e78
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoIosDynamicNat.java b/projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoIosDynamicNat.java
@@ -1,7 +1,6 @@
 package org.batfish.representation.cisco;
 
 import static com.google.common.base.Preconditions.checkArgument;
-import static org.batfish.datamodel.acl.AclLineMatchExprs.FALSE;
 import static org.batfish.datamodel.acl.AclLineMatchExprs.and;
 import static org.batfish.datamodel.acl.AclLineMatchExprs.permittedByAcl;
 import static org.batfish.datamodel.transformation.Transformation.when;
@@ -240,9 +239,6 @@ private Transformation.Builder makeTransformation(
       Map<String, Interface> interfaces) {
     if (_natPool != null) {
       NatPool pool = natPools.get(_natPool);
-      if (pool == null) {
-        return when(FALSE);
-      }
       return makeTransformation(shouldNat, pool.getFirst(), pool.getLast(), outgoing);
     } else {
       Ip ifaceAddress = interfaces.get(_interface).getAddress().getIp();

diff --git a/...s/batfish/src/test/resources/org/batfish/grammar/cisco/testconfigs/ios-nat-malformed-pool b/...s/batfish/src/test/resources/org/batfish/grammar/cisco/testconfigs/ios-nat-malformed-pool
@@ -7,5 +7,5 @@ interface Ethernet1
 ip access-list standard LIST
  permit 1.1.1.1 0.0.0.255
 ! Note the pool is not a valid range
-ip nat pool SNOOKER 10.161.151.222 10.161.151.30 netmask 255.255.255.0
+ip nat pool SNOOKER 10.1.1.10 10.1.1.5 netmask 255.255.255.0
 ip nat outside source list LIST pool SNOOKER