Juniper: support ospf area interface metric

[dhalperi]

• Fix inheritance (inverted condition on whether inheritance had been performed)
• Add parsing for metric configuration for an ospf area interface
• Add inheritance of ospf cost and ospf area
• Rename parameter in setOspfCost
• and test with new matchers and everthing.

[batfish-bot]

This change is 

[dhalperi]

Re inheritance break, the bug was introduced in 47e2823#diff-17db06163ef18e1161020de26c98df75L233 and Batfish 0.33.0

[arifogel]

with minor suggestions

---

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/matchers/InterfaceMatchersImpl.java, line 39 at r1 (raw file):

  static final class HasOspfCost extends FeatureMatcher<Interface, Integer> {
    HasOspfCost(@Nonnull Matcher<? super Integer> subMatcher) {
      super(subMatcher, "an interface with ospfCost", "ospfCost");

"an interface with ospfCost" -> "an interface with ospfCost:" is the new style I am trying to apply to all matchers (note the colon on the right).

---

projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java, line 178 at r1 (raw file):

    // Interface override
    assertThat(config.getInterfaces().get("fe-1/0/1.0"), hasOspfCost(equalTo(17)));

Personally I would do: assertThat(config, hasInterface("fe-1/0/1.0", hasOspfCost(equalTo(17))));, but I'll leave it to your preference.

---

Comments from Reviewable

[dhalperi]

Review status: 5 of 7 files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/matchers/InterfaceMatchersImpl.java, line 39 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

"an interface with ospfCost" -> "an interface with ospfCost:" is the new style I am trying to apply to all matchers (note the colon on the right).

Done.

---

projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java, line 178 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

Personally I would do: assertThat(config, hasInterface("fe-1/0/1.0", hasOspfCost(equalTo(17))));, but I'll leave it to your preference.

Done.

---

Comments from Reviewable

[dhalperi]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable