Identify metamako configuration format

[corinaminer]

Identifies Metamako configurations by the phrase "username admin secret". As far as I could tell with the configurations at hand, that phrase appears in only and all Metamako device configurations. @saparikh @arifogel will that work more broadly, as far as you know?

[batfish-bot]

This change is 

[dhalperi]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 188 at r1 (raw file):

  @Nullable
  private ConfigurationFormat checkMetamako() {
    if (_fileText.contains("username admin secret")) {

So the goal of this part of the code is to find something that is unique to the vendor at hand. In this case, I think this is actually very common (Metamako, like many others, seems to be Cisco-like).

The better detector might be something that finds lines like these:

! device: <foo> (A32-A7, MOS-0.13.25)
! device: <foo> (A32-A5, MOS-0.14.0)

Especially since the MOS-#.#.# is the part that relates to Metamako's "Metamako Operating System (MOS)".

I would use a gracious regex to catch lines like this.

---

Comments from Reviewable

[corinaminer]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 188 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

So the goal of this part of the code is to find something that is unique to the vendor at hand. In this case, I think this is actually very common (Metamako, like many others, seems to be Cisco-like).

The better detector might be something that finds lines like these:

! device: <foo> (A32-A7, MOS-0.13.25)
! device: <foo> (A32-A5, MOS-0.14.0)

Especially since the MOS-#.#.# is the part that relates to Metamako's "Metamako Operating System (MOS)".

I would use a gracious regex to catch lines like this.

isn't that a comment that could be changed arbitrarily? seems like most of the other possible formats are identified by unique phrases in the config text.

---

Comments from Reviewable

[corinaminer]

Devices are now identified as Metamako if they have any of the following:

• the phrase "application metamux"
• the phrase "application metawatch"
• a line ! device: [at least one non-newline char] MOS-[number].[number].[number])

Of 29 sample Metamako configurations, 21 matched (at least) one of the first two criteria; all of them matched the third.

---

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 188 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

isn't that a comment that could be changed arbitrarily? seems like most of the other possible formats are identified by unique phrases in the config text.

Added better identification criteria.

---

Comments from Reviewable

[dhalperi]

Tests are failing because there are tests for it. I'm of mixed opinion -- we don't have grammar or interesting tests of this stuff -- as indicated by the failing cisco-assumptions that led to this work -- but we do parse its structure somewhat usefully in a cisco-like way right now.

@arifogel thoughts?

---

Review status: 2 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 191 at r2 (raw file):

      return ConfigurationFormat.METAMAKO;
    }
    Matcher deviceDescription =

why two ifs vs three things || together?

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 192 at r2 (raw file):

    }
    Matcher deviceDescription =
        Pattern.compile("(?m)^! device: [^\\n]+ MOS-\\d+\\.\\d+\\.\\d+\\)$").matcher(_fileText);

compile the regex once (private static final METAMAKO_MOS_PATTERN = Pattern.compile..), then use the compiled Pattern's function instead to do the match.

---

Comments from Reviewable

[dhalperi]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[arifogel]

As discussed offline, this format for now should be detected but unsupported.

---

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[corinaminer]

Review status: 2 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 191 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

why two ifs vs three things || together?

it was to avoid creating the matcher for ~75% of metamako configurations. new setup manages to do that without splitting up the if.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 192 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

compile the regex once (private static final METAMAKO_MOS_PATTERN = Pattern.compile..), then use the compiled Pattern's function instead to do the match.

done for this and all other patterns in the file

---

Comments from Reviewable

[dhalperi]

---

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/grammar/VendorConfigurationFormatDetector.java, line 192 at r2 (raw file):

Previously, corinaminer (Corina Miner) wrote…

done for this and all other patterns in the file

In future, would prefer wide-scale refactoring changes in a separate PR. It confuses this PR (e.g., if we want to revert this PR we revert the refactoring) and is not a blocker for this PR.

LGTM.

---

Comments from Reviewable