Interface: switch allowedVlans to IntegerSpace #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #2616 +/- ##
============================================
- Coverage 70.55% 70.55% -0.01%
+ Complexity 19078 19072 -6
============================================
Files 1700 1700
Lines 85823 85818 -5
Branches 10486 10484 -2
============================================
- Hits 60556 60552 -4
+ Misses 20922 20920 -2
- Partials 4345 4346 +1 |
progwriter
reviewed
Nov 10, 2018
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.