Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linking videos from the README #2775

Merged
merged 2 commits into from Dec 7, 2018
Merged

linking videos from the README #2775

merged 2 commits into from Dec 7, 2018

Conversation

millstein
Copy link
Contributor

mirrors a recent update to the pybatfish README

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@saparikh saparikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #2775 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2775      +/-   ##
============================================
+ Coverage     71.45%   71.52%   +0.07%     
- Complexity    19730    19878     +148     
============================================
  Files          1734     1734              
  Lines         87369    87638     +269     
  Branches      10597    10713     +116     
============================================
+ Hits          62427    62684     +257     
- Misses        20522    20537      +15     
+ Partials       4420     4417       -3

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 9ff95a7 into master Dec 7, 2018
@dhalperi dhalperi deleted the link-videos-in-readme branch December 7, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants